Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Zipkin otel #1323

Merged
merged 19 commits into from
Feb 7, 2023
Merged

feat: Zipkin otel #1323

merged 19 commits into from
Feb 7, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: #1312
Fixes: FLI-195

Adds support and examples for configuring Zipkin for OTel trace data

@markphelps markphelps requested a review from a team as a code owner February 6, 2023 19:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #1323 (0611157) into main (b06b5fe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   80.78%   80.79%   +0.01%     
==========================================
  Files          43       43              
  Lines        3330     3333       +3     
==========================================
+ Hits         2690     2693       +3     
  Misses        512      512              
  Partials      128      128              
Impacted Files Coverage Δ
internal/config/tracing.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pedantic comment in a couple places. Otherwise, this looks awesome.

examples/tracing/jaeger/README.md Outdated Show resolved Hide resolved
examples/tracing/zipkin/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pedantic comment in a couple places. Otherwise, this looks awesome.

markphelps and others added 2 commits February 7, 2023 09:19
Co-authored-by: George <me@georgemac.com>
Co-authored-by: George <me@georgemac.com>
@markphelps markphelps merged commit 2b2fed8 into main Feb 7, 2023
@markphelps markphelps deleted the zipkin-otel branch February 7, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-195] OTel: Support Zipkin exporter
3 participants