Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OTLP Exporter #1324

Merged
merged 27 commits into from
Feb 8, 2023
Merged

feat: OTLP Exporter #1324

merged 27 commits into from
Feb 8, 2023

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Feb 7, 2023

Fixes: #1311
Fixes: FLI-196

  • Adds support for OpenTelemetry Protocol exporter
  • Renames tracing.backend to tracing.exporter because I'm indecisive
  • Cleans up examples for tracing/examples
  • Updates all docker-compose examples to run --force-migrate to make sure they work with latest changes

@markphelps markphelps requested a review from a team as a code owner February 7, 2023 17:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #1324 (da2689b) into main (af7a0be) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
+ Coverage   80.78%   80.81%   +0.03%     
==========================================
  Files          43       43              
  Lines        3330     3336       +6     
==========================================
+ Hits         2690     2696       +6     
  Misses        512      512              
  Partials      128      128              
Impacted Files Coverage Δ
internal/config/config.go 88.83% <ø> (ø)
internal/config/deprecations.go 100.00% <ø> (ø)
internal/config/tracing.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tiny suggestions. Otherwise, looks solid.

config/flipt.schema.cue Outdated Show resolved Hide resolved
examples/openfeature/docker-compose.yml Outdated Show resolved Hide resolved
markphelps and others added 2 commits February 8, 2023 09:18
@markphelps markphelps enabled auto-merge (squash) February 8, 2023 14:30
@markphelps markphelps merged commit b433bd0 into main Feb 8, 2023
@markphelps markphelps deleted the otlp branch February 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-196] OTel: Support OTLP export
3 participants