Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump multiple otel dependencies and fix API changes #1326

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

GeorgeMac
Copy link
Contributor

I've hijacked the dependency updates for the following dependabot PRs:

This is because the bump in otel dependency was a breaking change.
The metrics portion is considered Beta which lets them break stuff into minor patches.

This updates all the call sites to use the new definitions introduced around version 1.13.
We can close all of those and replace them with this.

dependabot bot and others added 3 commits February 8, 2023 14:33
Bumps [github.com/XSAM/otelsql](https://github.com/XSAM/otelsql) from 0.17.1 to 0.18.0.
- [Release notes](https://github.com/XSAM/otelsql/releases)
- [Changelog](https://github.com/XSAM/otelsql/blob/main/CHANGELOG.md)
- [Commits](XSAM/otelsql@v0.17.1...v0.18.0)

---
updated-dependencies:
- dependency-name: github.com/XSAM/otelsql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@GeorgeMac GeorgeMac requested a review from a team as a code owner February 9, 2023 11:16
@codecov-commenter
Copy link

Codecov Report

Merging #1326 (f82658d) into main (af7a0be) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   80.78%   80.81%   +0.03%     
==========================================
  Files          43       43              
  Lines        3330     3336       +6     
==========================================
+ Hits         2690     2696       +6     
  Misses        512      512              
  Partials      128      128              
Impacted Files Coverage Δ
internal/config/config.go 88.83% <ø> (ø)
internal/config/deprecations.go 100.00% <ø> (ø)
internal/config/tracing.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! just 2 minor doc nits

internal/metrics/metrics.go Outdated Show resolved Hide resolved
internal/metrics/metrics.go Outdated Show resolved Hide resolved
Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@GeorgeMac GeorgeMac added the automerge Used by Kodiak bot to automerge PRs label Feb 9, 2023
@kodiakhq kodiakhq bot merged commit 2bb1b06 into main Feb 9, 2023
@kodiakhq kodiakhq bot deleted the gm/otel-v1.13 branch February 9, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants