chore: change to segmentKeys for future proofing #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yquansah
approved these changes
Jul 28, 2023
into rollouts-segmentKeys * 'rollouts-segmentKeys' of https://github.com/flipt-io/flipt: chore(production): use same configuration for default chore(rollouts): account for segments without constraints
Codecov Report
@@ Coverage Diff @@
## main #1918 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 66 66
Lines 6455 6455
=======================================
Hits 4606 4606
Misses 1592 1592
Partials 257 257
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* main: chore: disallow rollouts eval UI (#1917)
into rollouts-segmentKeys * 'rollouts-segmentKeys' of https://github.com/flipt-io/flipt:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
segmentKeyfor new evaluation API for/variantto besegmentKeysto support future #1882