Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show placeholder for entity id oneof* constraint #2799

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Feb 24, 2024

No description provided.

@erka erka requested a review from a team as a code owner February 24, 2024 16:02
@yquansah
Copy link
Contributor

Good shout

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (f997fb9) to head (362c4cb).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
+ Coverage   70.78%   72.29%   +1.50%     
==========================================
  Files          91       92       +1     
  Lines        8729     7053    -1676     
==========================================
- Hits         6179     5099    -1080     
+ Misses       2165     1568     -597     
- Partials      385      386       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@markphelps markphelps merged commit 1354b0a into flipt-io:main Feb 24, 2024
29 of 30 checks passed
@erka erka deleted the ui-placeholder-entity-id-contraint branch February 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants