Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): evaluation console provides the warning for user about context values #2937

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Apr 2, 2024

closes #2909

screenshot

This is not ideal solution but it's provide a better understanding of the issue

@erka erka requested a review from a team as a code owner April 2, 2024 19:13
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (f997fb9) to head (2d3feb3).
Report is 201 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
+ Coverage   70.78%   72.23%   +1.44%     
==========================================
  Files          91       91              
  Lines        8729     7056    -1673     
==========================================
- Hits         6179     5097    -1082     
+ Misses       2165     1579     -586     
+ Partials      385      380       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing @erka !!! thank you!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Apr 2, 2024
@kodiakhq kodiakhq bot merged commit a095830 into flipt-io:main Apr 2, 2024
27 checks passed
@erka erka deleted the ui-console-context-values branch April 2, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Evaluation console does not allow non-string context values e.g. boolean or integer
2 participants