Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/git): add support for a directory scope #2939

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

GeorgeMac
Copy link
Contributor

Supports flipt-io/flipt-server-sdks#158

This adds support for users specifying a directory context with the git type storage backend.
When declared the backend will perform its flag state location process rooted from the defined directory.

This would allow folks to deploy Flipt multiple times over the same repository for e.g. different environments.
Environments can then be modelled as directories instead of namespaces or branches in this situation.

TODO

  • Update docs

@GeorgeMac GeorgeMac requested a review from a team as a code owner April 3, 2024 10:03
@markphelps markphelps added the needs docs Requires documentation updates label Apr 3, 2024
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@GeorgeMac
Copy link
Contributor Author

small update: I did the CUE and Jsonschema

@GeorgeMac GeorgeMac enabled auto-merge (squash) April 3, 2024 12:53
@GeorgeMac GeorgeMac merged commit 4aca093 into main Apr 3, 2024
28 checks passed
@GeorgeMac GeorgeMac deleted the gm/git-directory-scope branch April 3, 2024 12:57
@sylwang
Copy link

sylwang commented Apr 3, 2024

Thanks so much guys! Would it be possible to get this released by this week? We're working on an infrastructure setup that is dependent on this and would like to have it on the main branch sooner. I totally understand if that is too much to ask. I appreciate your help!

@markphelps
Copy link
Collaborator

@sylwang yah I think we can definitely get a new release out this week (likely tomorrow). Just need to check with the rest of the group to see if there's anything else we want to get in before release

@markphelps markphelps removed the needs docs Requires documentation updates label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants