Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support remote blob storage for service configuration #2983

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Apr 13, 2024

closes #2862

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 72.32%. Comparing base (f997fb9) to head (2ecbd02).
Report is 230 commits behind head on main.

Files Patch % Lines
internal/config/config.go 62.50% 6 Missing and 6 partials ⚠️
internal/storage/fs/object/mux.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
+ Coverage   70.78%   72.32%   +1.54%     
==========================================
  Files          91       95       +4     
  Lines        8729     7217    -1512     
==========================================
- Hits         6179     5220     -959     
+ Misses       2165     1602     -563     
- Partials      385      395      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka marked this pull request as ready for review April 13, 2024 20:51
@erka erka requested a review from a team as a code owner April 13, 2024 20:51
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it out locally with minio, works great!! thanks @erka. amazing work as always

one minor comment about test name

FYI this is how I tested:

  1. installed minio via homebrew
  2. ran minio server: MINIO_ACCESS_KEY=admin MINIO_SECRET_KEY=password minio server ~/minio
  3. Logged in to minio UI with admin/password at http://localhost:59134
  4. Created bucket flipt
  5. Uploaded default config AFTER changing the GRPC server port to 9001 as it conflicts with minio default port
  6. Ran Flipt with AWS_ACCESS_KEY=admin AWS_SECRET_ACCESS_KEY=password ./bin/flipt --config="s3://flipt/config.yml?region=minio&endpoint=http://localhost:9000"

internal/config/config_test.go Outdated Show resolved Hide resolved
@markphelps markphelps added the needs docs Requires documentation updates label Apr 13, 2024
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Apr 14, 2024
@kodiakhq kodiakhq bot merged commit 91cc1b9 into flipt-io:main Apr 14, 2024
28 checks passed
@erka erka deleted the remote-configuration branch April 14, 2024 12:07
@markphelps markphelps removed the needs docs Requires documentation updates label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-911] Remote config
2 participants