Attempt to fix mysql schema #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It looks like this is required for mysql 5.x support, but the original syntax is compatible with mysql 8 |
markphelps
pushed a commit
that referenced
this pull request
Jun 29, 2020
* WIP * Redo * Postgres * sqlite * Fix tests * Rm unneeded stuff * More mysql * Migration file * WIP * Single store; TODO: caching * Use dburl lib * Fix mysql url * Rm healthcheck command * Reparse url * Root * Switch back pg * need to fix migrations * Update migrator * Getting there * Fix mysql timestamps * Add back assert errors * missed one * Add back cache support * Almost there * fix sorting for distributions * Wat * Mod tidy * current_timestamp * Attempt to fix mysql schema (#304) * Use double quotes in queries * Try and fix pq err code * Use pq err code name * Forgot one * Back to backticks * Come on Postgres * pointers * OMG * sleeps * Unembed store in server; fix tests; mod tidy * Moving things * Add Example; fix migrator * Bump go-version * Add migrate test * Fix mysql ports; bump changelog * Update README * Comment out failing tests for now Co-authored-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.