test(integration): add failing case for rules with no distributions #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George MacRorie <me@georgemac.com>
Signed-off-by: George MacRorie <me@georgemac.com>
Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
force-pushed
the
gm/fix-snapshot-rule-not-found
branch
from
516f570
to
1160345
Compare
Signed-off-by: George MacRorie <me@georgemac.com>
Signed-off-by: George MacRorie <me@georgemac.com>
markphelps
approved these changes
May 13, 2024
markphelps
pushed a commit
that referenced
this pull request
May 13, 2024
…3078) * test(integration): add failing case for rules with no distributions Signed-off-by: George MacRorie <me@georgemac.com> * test(storage/fs): add failing case around no rule distributions Signed-off-by: George MacRorie <me@georgemac.com> * fix(storage/fs): return empty slice instead of rule not found Signed-off-by: George MacRorie <me@georgemac.com> * fix(testing/integration): update assertion to account for new flag cases Signed-off-by: George MacRorie <me@georgemac.com> * fix(testing/integration): update assertion to account for new flag cases Signed-off-by: George MacRorie <me@georgemac.com> --------- Signed-off-by: George MacRorie <me@georgemac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3076
See failing test case:
This fixes
GetEvaluationDistributionsto retun an empty set, instead of rule not found when a rule is defined with no distirbutions.