Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): allow change top bar theme color #3128

Merged
merged 2 commits into from
May 31, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented May 28, 2024

closes #3080

@erka erka force-pushed the ui-topbar-customization branch from dad41a8 to 2f5b227 Compare May 28, 2024 14:55
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.72%. Comparing base (f997fb9) to head (4b73eb1).
Report is 378 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   70.78%   71.72%   +0.93%     
==========================================
  Files          91      106      +15     
  Lines        8729     7862     -867     
==========================================
- Hits         6179     5639     -540     
+ Misses       2165     1784     -381     
- Partials      385      439      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the ui-topbar-customization branch 2 times, most recently from 6ee7387 to 8dca6e1 Compare May 31, 2024 17:40
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka force-pushed the ui-topbar-customization branch from 8dca6e1 to 346cedf Compare May 31, 2024 18:50
@erka
Copy link
Collaborator Author

erka commented May 31, 2024

I don't have a good place for label. I suggest to modify the page title with the custom label as a temporary solution.

@erka erka added the needs docs Requires documentation updates label May 31, 2024
@erka erka marked this pull request as ready for review May 31, 2024 19:01
@erka erka requested a review from a team as a code owner May 31, 2024 19:01
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question re validation of hex colors

internal/config/ui.go Show resolved Hide resolved
ui/src/App.tsx Show resolved Hide resolved
@markphelps
Copy link
Collaborator

with LinkedIn branded colors for testing!

CleanShot 2024-05-31 at 15 17 26

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks @erka

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label May 31, 2024
@kodiakhq kodiakhq bot merged commit 17db412 into flipt-io:main May 31, 2024
29 checks passed
@erka erka deleted the ui-topbar-customization branch May 31, 2024 20:46
@danilobuerger
Copy link

Thanks @erka ! Are you planning on adding the label to the topbar?

@erka
Copy link
Collaborator Author

erka commented Jun 14, 2024

Are you planning on adding the label to the topbar?

@danilobuerger Thank you for reaching out. Yes, we are considering adding the label to the topbar. However, we haven't finalized the exact placement yet. If you have any preferences or suggestions on where you'd like to see it, we'd love to hear your thoughts.

@danilobuerger
Copy link

@erka Thats awesome! I don't really have a suggestion on the placement, just that it should be big and visible (for example displaying "Warning - Production").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs needs docs Requires documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change bar theme or add a environment label
3 participants