Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(build): move to new dagger v0.11.8 #3144

Merged
merged 13 commits into from
Jun 20, 2024
Merged

refactor(build): move to new dagger v0.11.8 #3144

merged 13 commits into from
Jun 20, 2024

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jun 4, 2024 •
edited
Loading

This is a bit of a big one.

The PR upgrades us from old Dagger land (pre 0.10.x) to v0.11.8.
Most notibly, dagger comes with its own wrapping CLI now (dagger call ...).
This has meant I ended up doing a lot of shifting us from Mage to purely Dagger based build CLI.

New commands:

dagger call build --source=. # builds a flipt container

dagger call test --source=. unit # runs unit tests
dagger call test --source=. integration # [--cases ""] runs the IT suite (I recommend doing on a case by case basis)
dagger call test --source=. cli # runs the CLI tests
dagger call test --source=. migration # runs the tests to ensure backwards compat DB migration
dagger call test --source=. load # runs a load test

dagger call generate --source=. screenshots # regenerate all the in app screenshots

Outstanding in this PR:

  • Update all the documentation
  • Update the top-level mage-file entrypoint

@GeorgeMac GeorgeMac force-pushed the gm/dagger-refactor branch 2 times, most recently from 6babd1e to dfe1efe Compare June 4, 2024 15:59
@markphelps markphelps mentioned this pull request Jun 5, 2024
Merged
This was referenced Jun 6, 2024
Merged
Merged
GeorgeMac and others added 3 commits June 17, 2024 18:50
@GeorgeMac @markphelps
refactor(build): move to new dagger v0.11.6
213124e 
Signed-off-by: George MacRorie <me@georgemac.com>
@levlaz @markphelps
add docstrings (#3145)
538f338 
this makes running `dagger functions` and `dagger call test --help` via
the CLI a bit more useful.
@levlaz @markphelps
refactor gh workflow (#3189)
222461d 
* update to latest dagger 0.11.7
* use dagger-for-github action

Signed-off-by: Lev Lazinskiy <lev@dagger.io>
@GeorgeMac GeorgeMac changed the title refactor(build): move to new dagger v0.11.6 refactor(build): move to new dagger v0.11.8 Jun 20, 2024
markphelps
markphelps reviewed Jun 20, 2024
View reviewed changes
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
build/internal/flipt.go Outdated Show resolved Hide resolved
@GeorgeMac GeorgeMac marked this pull request as ready for review June 20, 2024 14:16
@GeorgeMac GeorgeMac requested a review from a team as a code owner June 20, 2024 14:16
@GeorgeMac
chore(build): update readme code block
9917171 
Signed-off-by: George MacRorie <me@georgemac.com>
markphelps
markphelps approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tackling this!!!

@GeorgeMac GeorgeMac merged commit 416a899 into main Jun 20, 2024
34 checks passed
@GeorgeMac GeorgeMac deleted the gm/dagger-refactor branch June 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeorgeMac @markphelps @levlaz