Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default variant redo #3271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: default variant redo #3271

wants to merge 1 commit into from

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Jul 12, 2024

Redo of #3168

Re: #3134

TODO

  • Add tests
  • Implement in UI
  • Add for other relational dbs
  • Think about/implement in non-relational dbs
  • Add to API docs
  • Add to client-side eval logic
  • Update OpenFeature providers

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (3e72b57) to head (9e88dc5).

Files Patch % Lines
internal/server/evaluation/legacy_evaluator.go 7.69% 8 Missing and 4 partials ⚠️
internal/storage/sql/common/flag.go 73.07% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3271      +/-   ##
==========================================
- Coverage   64.09%   64.05%   -0.05%     
==========================================
  Files         168      168              
  Lines       13393    13417      +24     
==========================================
+ Hits         8584     8594      +10     
- Misses       4149     4158       +9     
- Partials      660      665       +5     
Flag Coverage Δ
unittests 64.05% <51.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant