Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sub-effecting (as an option) #7912

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: sub-effecting (as an option) #7912

merged 3 commits into from
Jun 20, 2024

Conversation

JonathanStarup
Copy link
Contributor

@JonathanStarup JonathanStarup commented Jun 20, 2024 •
edited
Loading

We can now choose

--Xsubeffecting nothing
--Xsubeffecting lambdas
--Xsubeffecting lambdas-and-instances
--Xsubeffecting lambdas-and-defs

with nothing being default, thereby not changing anything

@JonathanStarup
Copy link
Contributor Author

@magnus-madsen this could be nice to have merged in to reduce the amount of non-merged code. it does nothing per default

@magnus-madsen
Copy link
Member

@magnus-madsen this could be nice to have merged in to reduce the amount of non-merged code. it does nothing per default

OK. I will take a look soon!

@magnus-madsen
Copy link
Member

You may want tests. It helps ensure the flag is propagated correctly.

@JonathanStarup
Copy link
Contributor Author

I tested it manually if thats enough

@magnus-madsen magnus-madsen enabled auto-merge (squash) June 20, 2024 15:18
@magnus-madsen magnus-madsen merged commit f045abf into flix:master Jun 20, 2024
13 checks passed
@JonathanStarup JonathanStarup deleted the sub-effecting branch June 20, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnus-madsen magnus-madsen magnus-madsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanStarup @magnus-madsen