feat: update LabelCompleter with # for RecordSelect

[jaschdoc]

• Perform manual tests in VSCode using updated Parser from feat: rework record syntax to # #7914

Related to #7897

[jaschdoc]

I'm not quite sure why this does not work yet. Is there some other place that I have to update things for LSP to work?

[magnus-madsen]

This may be enough. You can rebase, build a JAR and try it out.

[jaschdoc]

I did that locally with the updated parser but it didn't seem to work :/

[magnus-madsen]

I did that locally with the updated parser but it didn't seem to work :/

Can you paste the program you used? Also double check if # has to be escape in regex world.

[magnus-madsen]

Also, in the previous regex, what did [] do?

[jaschdoc]

I did that locally with the updated parser but it didn't seem to work :/

Can you paste the program you used? Also double check if # has to be escape in regex world.

The # symbol is not used for anything according to the java documentation https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html so I think it's fine to use as a literal. I think [] was used to use . as a literal since it can mean any character if it's not escaped or used in [].
The original regex was (.*)[.].* updated to (.*)#.* meaning any character zero or more times, then a hash, then any character zero or more times.
I also tried (.*)[#].* but IntelliJ suggested I remove the [] since it means any of the 1 characters.

[jaschdoc]

Here is my test program:

def main(): Unit \ IO =
    let r = { abcde = { bcdef = { cdefg = 2 } }, x = 3 };
    let s = r.abcde.bcdef.cdefg;
    println(s)

[jaschdoc]

Also the current impl is wrong since it suggests labels that do not exist. It should only suggest r.abcde.bcdef.

[magnus-madsen]

Also the current impl is wrong since it suggests labels that do not exist. It should only suggest r.abcde.bcdef.

That is a known limitation, so its an orthogonal issue.

Perhaps # does not trigger autocomplete? I seem to remember there is something called autocomplete chars somewhere. Maybe in the VSCode repo? But I guess you can trigger it manually and still not see anything?

[jaschdoc]

Yeah, hitting ctrl+space to load suggestions just gives all functions in the std lib

[jaschdoc]

Okay here's a weird bug: I'm using the updated compiler that I built locally where the updated parser is merged but it still runs the above program just fine when using . instead of #... how? It even says in the output that it's using the jar that I put in the root of the vscode project.

[magnus-madsen]

You need to make a change in Weeder2 too... See the original ticket.

[jaschdoc]

Ah ok I misunderstood what you meant so I reverted the weeder change in the last PR

[jaschdoc]

Note (to self): There may be something with triggerCharacters. Try searching for it on https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion

[jaschdoc]

I will do some manual testing once flix/vscode-flix#419 is merged

[magnus-madsen]

I will do some manual testing once flix/vscode-flix#419 is merged

I pushed a new version of the extension.

[jaschdoc]

It works now!