Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom compiler path #210

Closed
iacore opened this issue Jul 8, 2022 · 7 comments
Closed

Allow custom compiler path #210

iacore opened this issue Jul 8, 2022 · 7 comments

Comments

@iacore
Copy link

iacore commented Jul 8, 2022

This extension doesn't support custom compiler path yet. I hope it does, because I put flix.jar in some other place.

I'm not sure how should I add this feature. I tried, but failed. See #209

Also, I hope this extension looks for flix on PATH.

@magnus-madsen
Copy link
Member

Do you think we should add an option the plugin where you can specify the path?

@iacore
Copy link
Author

iacore commented Jul 8, 2022

Yes. Also add bundling and don't include every file in this repo.

@magnus-madsen
Copy link
Member

Yes. Also add bundling and don't include every file in this repo.

What do you mean by bundling?

@iacore
Copy link
Author

iacore commented Jul 10, 2022

With rollup or esbuild and .vscodeignore. Currently running vsce package includes every file in this repo.

@magnus-madsen
Copy link
Member

With rollup or esbuild and .vscodeignore. Currently running vsce package includes every file in this repo.

Right. That is tracked in #70.

@manoj2601
Copy link
Contributor

Maybe I can help with this issue. We can add a box in the extension settings where the users can provide the custom path for Flix compiler. (if they want to put flix.jar in some other places).

Users can provide the custom path as follows:
image

PR for this issue #225

@magnus-madsen
Copy link
Member

At the moment, we do not plan to support this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants