Add support of numeric values of mods #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ function normalize(dep, options) { | |||
| }); | |||
| } else { | |||
| Object.keys(dep.mods).forEach(function(mod) { | |||
| if (typeof dep.mods[mod] === 'string' || typeof dep.mods[mod] === 'boolean') { | |||
| if (!Array.isArray(dep.mods[mod])) { | |||
There was a problem hiding this comment.
why did you remove all the previous checks?
There was a problem hiding this comment.
seems to be the same. If you do not like, I can return the full condition
|
Thanks for pull-request! |
|
looks good and reasonable, but Im confused with checks on line 66 |
floatdrop
added a commit
that referenced
this pull request
Jul 17, 2015
Add support of numeric values of mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has appeared that mods can have numeric values :)