Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json files property #22

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Update package.json files property #22

merged 1 commit into from
Sep 14, 2022

Conversation

peterblazejewicz
Copy link
Contributor

Required to actually publish types.d.ts to NPM registry.

Thanks!

@peterblazejewicz
Update package.json files property
9bef8fa 
Required to actually publish `types.d.ts` to NPM registry.

Thanks!
@peterblazejewicz peterblazejewicz mentioned this pull request Jan 17, 2022
Merged
4 tasks
@AbrahamLopez10
Copy link

Can this be merged soon and published to NPM? Can't use express-request-id with TypeScript out of the box because of this, and even if I add @types/express-request-id, the req.id property is missing as it's defined in types.d.ts of this package.

@jfairley
Copy link

Need this!!

@jfairley
Copy link

@floatdrop any update?

@floatdrop floatdrop merged commit bf7c9ad into floatdrop:master Sep 14, 2022
@peterblazejewicz peterblazejewicz deleted the patch-1 branch September 14, 2022 19:01
@jfairley jfairley mentioned this pull request Sep 26, 2022
Closed
peterblazejewicz added a commit to peterblazejewicz/DefinitelyTyped that referenced this pull request Oct 5, 2022
@peterblazejewicz
remove(express-request-id): not needed as of v3.0.0
ef339ab 
floatdrop/express-request-id#22
https://github.com/floatdrop/express-request-id/releases/tag/v3.0.0

Thanks!
typescript-bot pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Oct 11, 2022
@peterblazejewicz
🤖 Merge PR #58200 🎉 remove 'express-request-id' as of 3.0.0 by @peter…
e8b5da6 
…blazejewicz

floatdrop/express-request-id#22
https://github.com/floatdrop/express-request-id/releases/tag/v3.0.0

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfairley jfairley jfairley approved these changes

@martin-badin martin-badin martin-badin approved these changes

@mpsijm mpsijm mpsijm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@peterblazejewicz @AbrahamLopez10 @jfairley @martin-badin @mpsijm @floatdrop