Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gulp-batch will call the callback more than once concurrently if it gets an event while running the callback. This is because the module-level
holdOn
variable is not correctly set to true (thevar holdOn = ...
should just beholdOn = ...
)!Only removing the extraneous
var
would cause gulp-batch to completely ignore events while the callback is running, which is undesirable. This patch stores events that occur during the callback, and - if any occurred - waits for the timeout interval after the callback ends and flushes them.