fix(types): avoid ts 4.2+ syntax (#2650)

floating-ui · Dec 6, 2023 · 23f32f5 · 23f32f5
1 parent cff301f
commit 23f32f5
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 22 deletions.
diff --git a/.changeset/fuzzy-swans-doubt.md b/.changeset/fuzzy-swans-doubt.md
@@ -0,0 +1,5 @@
+---
+'@floating-ui/core': patch
+---
+
+fix(types): avoid ts 4.2+ syntax
diff --git a/packages/core/src/detectOverflow.ts b/packages/core/src/detectOverflow.ts
@@ -10,7 +10,7 @@ import type {
   SideObject,
 } from './types';
 
-export type Options = Partial<{
+export type DetectOverflowOptions = Partial<{
   /**
    * The clipping element(s) or area in which overflow will be checked.
    * @default 'clippingAncestors'
@@ -53,7 +53,7 @@ export type Options = Partial<{
  */
 export async function detectOverflow(
   state: MiddlewareState,
-  options: Options | Derivable<Options> = {},
+  options: DetectOverflowOptions | Derivable<DetectOverflowOptions> = {},
 ): Promise<SideObject> {
   const {x, y, platform, rects, elements, strategy} = state;
 

diff --git a/packages/core/src/middleware/autoPlacement.ts b/packages/core/src/middleware/autoPlacement.ts
@@ -7,10 +7,8 @@ import {
   placements as ALL_PLACEMENTS,
 } from '@floating-ui/utils';
 
-import {
-  type Options as DetectOverflowOptions,
-  detectOverflow,
-} from '../detectOverflow';
+import type {DetectOverflowOptions} from '../detectOverflow';
+import {detectOverflow} from '../detectOverflow';
 import type {Alignment, Derivable, Middleware, Placement} from '../types';
 
 export function getPlacementList(

diff --git a/packages/core/src/middleware/hide.ts b/packages/core/src/middleware/hide.ts
@@ -1,9 +1,7 @@
 import {evaluate, sides} from '@floating-ui/utils';
 
-import {
-  type Options as DetectOverflowOptions,
-  detectOverflow,
-} from '../detectOverflow';
+import type {DetectOverflowOptions} from '../detectOverflow';
+import {detectOverflow} from '../detectOverflow';
 import type {Derivable, Middleware, Rect, SideObject} from '../types';
 
 function getSideOffsets(overflow: SideObject, rect: Rect) {

diff --git a/packages/core/src/middleware/shift.ts b/packages/core/src/middleware/shift.ts
@@ -6,10 +6,8 @@ import {
   getSideAxis,
 } from '@floating-ui/utils';
 
-import {
-  type Options as DetectOverflowOptions,
-  detectOverflow,
-} from '../detectOverflow';
+import type {DetectOverflowOptions} from '../detectOverflow';
+import {detectOverflow} from '../detectOverflow';
 import type {Coords, Derivable, Middleware, MiddlewareState} from '../types';
 
 export type ShiftOptions = Partial<

diff --git a/packages/core/src/middleware/size.ts b/packages/core/src/middleware/size.ts
@@ -7,10 +7,8 @@ import {
   min,
 } from '@floating-ui/utils';
 
-import {
-  type Options as DetectOverflowOptions,
-  detectOverflow,
-} from '../detectOverflow';
+import type {DetectOverflowOptions} from '../detectOverflow';
+import {detectOverflow} from '../detectOverflow';
 import type {Derivable, Middleware, MiddlewareState} from '../types';
 
 export type SizeOptions = Partial<

diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -184,10 +184,7 @@ export type RootBoundary = 'viewport' | 'document' | Rect;
 export type ElementContext = 'reference' | 'floating';
 
 export {computePosition} from './computePosition';
-export {
-  detectOverflow,
-  Options as DetectOverflowOptions,
-} from './detectOverflow';
+export {detectOverflow, DetectOverflowOptions} from './detectOverflow';
 export {arrow, ArrowOptions} from './middleware/arrow';
 export {autoPlacement, AutoPlacementOptions} from './middleware/autoPlacement';
 export {flip, FlipOptions} from './middleware/flip';