fix(useDismiss): targetRootAncestor for third party outside presses (#…

…2634)
floating-ui · Nov 25, 2023 · 9170b9e · 9170b9e
1 parent c6e899d
commit 9170b9e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/calm-schools-approve.md b/.changeset/calm-schools-approve.md
@@ -0,0 +1,7 @@
+---
+"@floating-ui/react": patch
+---
+
+fix(useDismiss): `targetRootAncestor` check for third party outside presses
+
+The Grammarly extension no longer closes upon clicking when inside floating elements.
diff --git a/packages/react/src/hooks/useDismiss.ts b/packages/react/src/hooks/useDismiss.ts
@@ -184,7 +184,7 @@ export function useDismiss<RT extends ReferenceType = ReferenceType>(
     let targetRootAncestor = isElement(target) ? target : null;
     while (targetRootAncestor && !isLastTraversableNode(targetRootAncestor)) {
       const nextParent = getParentNode(targetRootAncestor);
-      if (nextParent === getDocument(floating).body || !isElement(nextParent)) {
+      if (isLastTraversableNode(nextParent) || !isElement(nextParent)) {
         break;
       } else {
         targetRootAncestor = nextParent;