-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onCreate does not return popper instance #36
Comments
May you test the new ps. |
weird PR looks ok |
I know :( |
I applied your patch directly in the node_modules src in my project and it works fine. If it's just your test going wrong, check you're actually running them on src and not build. |
Yup the tests run on src... |
80aa0df should have fixed the problem once for all. The test was failing because new Popper()
.onUpdate(function(data) {
console.log(data);
})
.onCreate(function(instance) {
instance.update();
}) |
Tried to follow the documentation with
onCreate
onUpdate
but it cannot be chained.onCreate
returnundefined
The text was updated successfully, but these errors were encountered: