Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default for preventOverflow #611

Closed
FezVrasta opened this issue Apr 11, 2018 · 7 comments
Closed

Better default for preventOverflow #611

FezVrasta opened this issue Apr 11, 2018 · 7 comments
Labels
feature This would be nice to have. Fixed in popper@2.x This issue has been fixed in version 2.x PRIORITY: medium TARGETS: modifier Related to a modifier.

Comments

@FezVrasta
Copy link
Member

Bootstrap issue: twbs/bootstrap#25428

Basically, we want to have a better way to detect the "scrollParent" so that we don't include elements with overflow !== initial that will not actually cut out position: absolute elements.

@FezVrasta
Copy link
Member Author

For anyone that wants to try to implement this, basically there are cases when an element with overflow value different from initial (e.g. hidden or scroll) will not prevent its position: absolute children elements from overflowing it.

We should first find out when this happens, and then change the scrollParent detection algorithm to take in consideration these new finds so that we pick a better parent element.

@florianlacreuse
Copy link

Hi @FezVrasta. I just want to know if there is a chance this will be fixed any time soon? Thanks, keep up the good work!

@FezVrasta
Copy link
Member Author

No I haven't time to allocate at the moment, but I explained the needed steps here. A PR would be great.

@florianlacreuse
Copy link

Thanks for the feedback. Unfortunately I don't have the necessary skills in js to push a good PR. We'll use boundary window in the meantime.

florianlacreuse added a commit to igloo-project/igloo-parent that referenced this issue Aug 8, 2019
@FezVrasta FezVrasta added the Fixed in popper@2.x This issue has been fixed in version 2.x label Nov 26, 2019
@realnot
Copy link

realnot commented Apr 20, 2021

@florianlacreuse the issue is closed, but this is still unresolved with latest bootstrap 5 and popper.js. How did you solved?

@florianlacreuse
Copy link

I haven't solved it with BS4 and Popper.js v1 IIRC. This issue is marked as fixed in v2 but I haven't yet had the chance to test the v2.

@realnot
Copy link

realnot commented Apr 20, 2021

I haven't solved it with BS4 and Popper.js v1 IIRC. This issue is marked as fixed in v2 but I haven't yet had the chance to test the v2.

I just created a fiddle to reproduce the bug. As you can see, filter columns are not visible when you click the dropdown arrow.

https://jsfiddle.net/0ex91L46/

Can we re open this issue or create another one @FezVrasta ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This would be nice to have. Fixed in popper@2.x This issue has been fixed in version 2.x PRIORITY: medium TARGETS: modifier Related to a modifier.
Projects
None yet
Development

No branches or pull requests

3 participants