-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat 'pen' pointerType like 'mouse' in useHover hook #2016
Conversation
@floating-ui/react-dom-interactions (0.13.2 → 0.13.3)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
✅ Deploy Preview for vibrant-gates-22c214 canceled.
|
The first one has a spelling mistake Also, maybe need to add Also can you add this comment above the array: // On some Linux machines with Chromium, mouse inputs return a `pointerType` of
// "pen": https://github.com/floating-ui/floating-ui/issues/2015 |
Good catch @atomiks! I accidentally made that typo and "fixed it" but I must have hit Ctrl+Z once too often and undid it. |
@atomiks I'm not sure if it would be Edit Or we could just include I can't find any definitive answer on the fallback value for
This says "can be" but not "will be." |
|
Alright now we have both
One can never be certain, but I think it's a safe assumption. I think it's much less likely for |
I made these changes in the github.dev editor, so apologies if any linter requirement might not be met.
I made these changes to the
dist/floating-ui.react-dom-interactions.esm.js
locally, tested them, and then copied the changes to the source file - so there's an exceedingly small chance there was a transcription error on my part - but I believe this code to be functional and ready to go.@atomiks