Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try to speed up ci #2164

Merged
merged 15 commits into from Feb 5, 2023
Merged

chore: try to speed up ci #2164

merged 15 commits into from Feb 5, 2023

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Feb 4, 2023

This might, or probably will, break, but I'm trying to speed up the test suite in CI as it's slow when trying to add new tests and update the snapshots, and performing a release.

  • Switches (back) to Linux for visual snapshots: macOS is much slower than Linux, it was used because Linux was flakey sometimes (although macOS can be too, it's far less frequent). Hopefully it's not anymore?
  • Upgrade Node and Playwright versions: Uses Node 18, not 17 as there were warnings being emitted. Also Playwright was locked to 1.17.x because something was broken in 1.18.x. Can't remember, but I'm hoping it's fixed in the latest version as it's now pretty old.
  • Caching: I think npm install caching was broken? Upgrades to v3 versions of the actions and uses npm cache option
  • Increase workers and use "fullyParallel" option: I don't know if this will work or break something, but let's try it

Might also implement these in this PR as they seem important for speed:

  • Reduce number of screenshots for the shadow DOM test suite — this one appears to be by far the slowest as it has a combinatorial explosion of state being tested.
  • Don't use screenshots for offset(), just use regular unit tests. It's not really something that needs screenshots of, and it's the second slowest test suite.

@rollingversions
Copy link

There is no change log for this pull request yet.

Create a changelog

@netlify
Copy link

netlify bot commented Feb 4, 2023

Deploy Preview for vibrant-gates-22c214 canceled.

Name Link
🔨 Latest commit ee76192
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/63de7485566a250008f56107

@atomiks
Copy link
Collaborator Author

atomiks commented Feb 4, 2023

Looks much faster now:

  • Linting and type checking ~2x faster
  • Unit tests ~1.2x faster
  • Functional tests ~3x faster

Going to check for validity and flakiness then merge

@atomiks atomiks merged commit cf57d4a into master Feb 5, 2023
@atomiks atomiks deleted the chore/speed-ci branch February 5, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant