Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type exports and comments #2175

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: type exports and comments #2175

merged 1 commit into from
Feb 10, 2023

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Feb 10, 2023

Several issues:

  • Middleware option types weren't being re-exported from dependent packages (fixes Middleware types not re-exported from @floating-ui/core in dependent libraries #2169)
  • Some of the comments were outdated, not descriptive, or not matching the wrapped types correctly
  • Some of the wrapped DOM types look bad when hovering over types, I used the Prettify util found here
  • MiddlewareArguments has been deprecated in favor of MiddlewareState as it's shorter, cleaner, and is more descriptive
  • Added @deprecated comment to reference, floating, and positionReference values returned from useFloating

@rollingversions
Copy link

rollingversions bot commented Feb 10, 2023

@floating-ui/core (1.2.0 → 1.2.1)

Bug Fixes

  • fix(types): deprecate MiddlewareArguments in favor of MiddlewareState type

@floating-ui/dom (1.2.0 → 1.2.1)

Bug Fixes

  • fix(types): re-export middleware options types

@floating-ui/react (0.19.1 → 0.19.2)

Bug Fixes

  • fix(types): re-export middleware options types

  • fix(types): add @deprecation notice to non-ref nested element setters

@floating-ui/react-dom (1.2.2 → 1.2.3)

Bug Fixes

  • fix(types): re-export middleware options types

  • fix(types): add @deprecation notice to non-ref nested element setters

@floating-ui/vue (0.2.0 → 0.2.1)

Bug Fixes

  • fix(types): re-export middleware options types

Packages With No Changes

The following packages have no user facing changes, so won't be released:

  • @floating-ui/react-native

Edit changelogs

@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for vibrant-gates-22c214 canceled.

Name Link
🔨 Latest commit 6b3411c
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/63e6320e5498540008ba460b

@atomiks atomiks merged commit 8de3b14 into master Feb 10, 2023
@atomiks atomiks deleted the fix/types branch February 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware types not re-exported from @floating-ui/core in dependent libraries
1 participant