Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FloatingArrow): prevent transparency overlap, vertical sizing, default strokeWidth, strokeWidth doubling #2223

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Mar 12, 2023

No description provided.

@rollingversions
Copy link

rollingversions bot commented Mar 12, 2023

@floating-ui/dom (1.2.3 → 1.2.4)

Bug Fixes

  • fix(getDimensions): measure <svg> arrows with CSS sizes instead of getBoundingClientRect() to avoid reading transformations

@floating-ui/react (0.20.1 → 0.21.0)

Refactors

  • refactor(FloatingArrow): internally double strokeWidth so it matches borderWidth values

    ⚠️ strokeWidths larger than the floating element's borderWidth are not supported.

Bug Fixes

  • fix(FloatingArrow): prevent transparency overlap if the floating element border and stroke are both partially transparent

  • fix(FloatingArrow): ensure correct vertical size with larger stroke widths

  • fix(FloatingArrow): allow height > width

Packages With No Changes

The following packages have no user facing changes, so won't be released:

  • @floating-ui/core
  • @floating-ui/react-dom
  • @floating-ui/react-native
  • @floating-ui/vue

Edit changelogs

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for vibrant-gates-22c214 canceled.

Name Link
🔨 Latest commit 8a94ec7
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/640de91836f9c00008bc4b95

@atomiks atomiks force-pushed the fix/FloatingArrow-overlap-size branch from c4cadc5 to c10440d Compare March 12, 2023 14:48
@atomiks atomiks force-pushed the fix/FloatingArrow-overlap-size branch from c10440d to 8a94ec7 Compare March 12, 2023 15:00
@atomiks atomiks merged commit be47d12 into master Mar 12, 2023
@atomiks atomiks deleted the fix/FloatingArrow-overlap-size branch March 12, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant