chore: [Popper] remove process.env warnings
#2252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change log for this pull request yet. |
|
thank you so much @atomiks! |
benmccann
reviewed
Apr 10, 2023
| import orderModifiers from './utils/orderModifiers'; | ||
| import debounce from './utils/debounce'; | ||
| import validateModifiers from './utils/validateModifiers'; |
There was a problem hiding this comment.
it looks like you can probably delete src/utils/validateModifiers.js now as it appears the CI is complaining about it being unused
There was a problem hiding this comment.
src/utils/format.js needs to be deleted as well to get that CI check passing. I created a new branch to check what needed to be done here: #2296
|
This PR looks good to me except for the two files that need to be deleted to pass the CI check. The other CI check failures are unrelated to this PR as I've described in #2296 which is an updated version of this PR with those two files removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2251