Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed #276 #363

Merged
merged 1 commit into from Jul 26, 2017
Merged

[fix] Fixed #276 #363

merged 1 commit into from Jul 26, 2017

Conversation

FezVrasta
Copy link
Member

@FezVrasta FezVrasta commented Jul 23, 2017

I'm a bit concerned about performance problems...

These should/could kick in only when the returned offsetParent is a TD or a TABLE, but still..

@FezVrasta
Copy link
Member Author

I love how people don't give a fuck about all of this..

@pinkeen
Copy link

pinkeen commented Jul 27, 2017

It fixed the positioning issue for me 👍
However the tooltip gets inserted into the parent <tr> element what causes some rendering issues with the table.

@FezVrasta
Copy link
Member Author

what do you mean "gets inserted"? Popper doesn't touches the position of the nodes in the DOM three

@pinkeen
Copy link

pinkeen commented Jul 27, 2017

I'm sorry, I forgot that tooltip.js is a separate project. When using <td> as trigger the tooltip is appended to the parent <tr>. I don't know if I should file a bug report in tooltip. This being a special case concerning tables and requiring probably a dirty workaround maybe it's better to just force the container in my code.

@FezVrasta
Copy link
Member Author

Tooltip.js should append the tooltip to the parentNode of the reference element. Please file an issue if you see a different behavior

@pinkeen
Copy link

pinkeen commented Jul 27, 2017

That's what I was saying :) - there is no bug, it's appended correctly, although block element inside tr is a no go. This being a special case I will just force body as container.

Keep up the good work!

FezVrasta pushed a commit that referenced this pull request Aug 28, 2018
#363 fixed the positioning issue for td elements, but the problem still existed for th elements.
This PR adds a fix for th elements as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants