feat: use visibility instead of display for tooltip #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visibility can be animated, but display cannot. Because the tooltips already have
position: absolute
added, ultimately, this has no bearing on the way these tooltips work other than the fact that they can be animated more easily than display. For example, the below makes the tooltip fade in and out:whereas using
display
prevents theopacity
transition from happening, and the tooltip appears and disappears immediately after the first fade-in animation.Ultimately, it would be nice to add
.show
and.hide
classes to the tooltips to avoid using[aria-hidden]
as a way of identifying the states, but this can be added in a future PR if desired. For now, the main goal is to make everything animateable.