Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP-712: signTypedData #183

Merged
merged 23 commits into from Aug 25, 2019
Merged

Implement EIP-712: signTypedData #183

merged 23 commits into from Aug 25, 2019

Conversation

schmidsi
Copy link
Contributor

@schmidsi schmidsi commented Jul 19, 2019 •
edited

Note: This is a work-in-progress pull request and is not yet ready to merge.

Fixes #136

Next steps

  • Implement functionality with Ledger
  • Implement functionality with Trezor

Done

  • Give "sign" command down to main to actually sign message
  • Better styling of the data display
  • Bring data to renderer (app) and display it
  • Implement functionality in Seed Signer
  • Implement functionality in Ring Signer
  • Throw error if wrong chain (typedData.domain.chainId)

@schmidsi schmidsi closed this Jul 19, 2019
@schmidsi schmidsi reopened this Jul 19, 2019
@schmidsi schmidsi changed the title Implement EIP-712: signTypedData WIP: Implement EIP-712: signTypedData Jul 19, 2019
@schmidsi schmidsi force-pushed the eth_signTypedData branch 2 times, most recently from 46bae92 to 80cb85e Compare August 13, 2019 09:28
@schmidsi schmidsi mentioned this pull request Aug 13, 2019
Closed
@schmidsi
Copy link
Contributor Author

Seed Signer works now with https://dicether.com/

@schmidsi schmidsi mentioned this pull request Aug 15, 2019
Closed
@schmidsi
Copy link
Contributor Author

Unfortunately, Trezor and Ledger do not support EIP-712 at the moment :( (see #136). So I think this pull-request is good to go.

@schmidsi schmidsi changed the title WIP: Implement EIP-712: signTypedData Implement EIP-712: signTypedData Aug 15, 2019
@floating floating changed the base branch from 0.2 to signedTypedData August 15, 2019 21:45
@floating floating changed the base branch from signedTypedData to 0.2 August 15, 2019 21:48
@floating floating merged commit 20cf02e into floating:0.2 Aug 25, 2019
@schmidsi schmidsi deleted the eth_signTypedData branch August 27, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkybrain monkybrain Awaiting requested review from monkybrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmidsi @floating