-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beta.7 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>
* allow up to 40 Lattice addresses to be loaded * use account limit instead of store
* Hide account grabber for now * Add aragon ens registry for polygon * Split keystore and private key setup, clear setup after adding signer * Don't overwrite local state endpoint in chain setup * Move add chain to top * Update deps
* handle Ledger Nano X going to sleep * add reload functionality * cleanup * update USB adapter signature * add VSCode files to gitignore * remove signer test script
mholtzman
reviewed
Oct 15, 2021
mholtzman
reviewed
Oct 15, 2021
floating
commented
Oct 15, 2021
app/App/Panel/Main/Account/Requests/TransactionRequest/TxOverlay/TxFeeOverlay/index.js
Outdated
Show resolved
Hide resolved
} | ||
|
||
const loadedAddresses = await getAddresses(req) | ||
this.addresses = [...this.addresses, ...loadedAddresses] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to update each time we add new addresses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.