Docker

[sOckhamSter]

Hi @flobz - Here's my first attempt at containerisation of psa_car_controller:

https://github.com/sOckhamSter/docker_psa_car_controller
https://hub.docker.com/r/sockhamster/psa_car_controller/

My suggested run command is:

  docker run -ti --name psa_car_controller1 \
    --publish 8180:8180 \
    -v /host_path/config:/config \
    psa_car_controller

By default, this will start the container with command line access only, so just exec to bash:

docker exec -it psa_car_controller1 /bin/bash

... and then all of the standard setup can be done as per your readme. Once the app_decoder work has been completed, the test.json and charge_config1.json files should be moved to /config:

mv /psa_car_controller/test.json /config
mv /psa_car_controller/charge_config1.json /config

Then start the server for the first time to input the SMS/PIN:

python3 server.py -f /config/test.json -c /config/charge_config1.json -p 8180 -l 0.0.0.0 -r

Note: the IP address needs to be the wildcard 0.0.0.0 because it has to bind to whatever address the container has been given, and the port is 8180 because your default of 5000 conflicts with my Synology NAS...

Once it's all working, ctrl-c out of server.py and stop the container. Then edit the /config/dockerconfig.conf file that should be in the mapped folder and change the line to:

export SHELL_ONLY="FALSE"

Restart the container and server.py will automatically run as the main service.

Currently I have this sitting on my GitHub repo, but with your permission I'd like to merge those files into your repo. The main reason for that is because we can then enable auto-build on Docker Hub so every time you update your main branch, the Docker image will re-build automatically. Otherwise right now I would have to manually push an update to Docker and there would end up being a lag / SPOF on me.

[sOckhamSter]

Just to add to this, the one thing I can't figure out is where the SMS/PIN authentication response is being cached? If that response can somehow be placed in /config then it will persist between container refreshes. At the moment, every time the container is updated, you have to go through the SMS/PIN faff again. Any suggestions welcome!

[sOckhamSter]

Pull request is ready for you...

And yes, I agree a web configuration page would be a good idea. I'm not sure the best way for it to operate so it'll need a bit of thinking. Whether it just runs the required commands sequentially with a web-based CLI presentation, or if there's a fancier way to integrate with the scripts I'm not sure. Something to discuss and have a play around with I guess once we have this version live and working.

[flobz]

I merge your PR and did some modification #106.
Thanks !

[sOckhamSter]

Thank you. <edited to remove my comment about documentation... I see what you did by moving the file!>

[sOckhamSter]

Also, I need to link my Docker image on Docker Hub to your repo. In order to do that I think you need to grant me some form of access to your GitHub repo? I think I need to be added to the organisation/team? Alternatively if you have a Docker account, I can grant you access to the Docker Hub repo and you can delete my 'sOckhamSter' repo link and change it to a 'flobz' one? Is your Docker username flobz?

[flobz]

I choose the second option, and I add a github action to automatically build the docker image. Thanks for your contribution.

[dakoal]

Hi.

I have a problem running the last docker image on Synology Docker.
everything is running, I see SOC of my e-208 updating and so on, but http requests are running into a 404:

command line output:
2021-05-28 10:41:46,474 :: INFO :: charging status of XXXXXXXXXXXXXXXX is Disconnected, battery level: 83
xxx.xxx.xxx.xxx - - [28/May/2021 10:42:35] "GET / HTTP/1.1" 404 -

On a browser window I get:
Not Found
The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.

Started with this:
python3 /psa_car_controller/server.py -f /config/test.json -c /config/charge_config1.json -p 8180 -l 0.0.0.0 -r -b /config

And configured in Docker 8180:8180

[sOckhamSter]

I'm also running on Synology. There's no need to change the port that server.py is running on - you can leave -p as 5000 because when it auto-runs after the initial configuration, init.sh will start it on port 5000 anyway and that's not user-configurable. In Synology's Docker interface, just map 8180:5000 instead and then it'll respond on 8180 externally, but use 5000 behind the scenes. Also, you don't need the '-b /config' part.

[dakoal]

Great thank you, that was it.