Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trip map #478

Merged
merged 1 commit into from Apr 13, 2023
Merged

Fix trip map #478

merged 1 commit into from Apr 13, 2023

Conversation

Petapton
Copy link
Contributor

I think this addresses #302 and #270.

@flobz
Copy link
Owner

flobz commented Apr 1, 2023

can you give me more explanation ?

@Petapton
Copy link
Contributor Author

There is a bug in the current implementation of "map" tab. The missing , null when pushing new coordinates makes trip data to fall out of phase.
Different trips are delimited by (lat, lon) = (null, null). However, for some reason, the null value is only pushed for latitude, making the whole trip map inconsistent.

@flobz
Copy link
Owner

flobz commented Apr 13, 2023

ok thanks ! :)

@flobz flobz merged commit b7c61fa into flobz:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants