Possible Firefox memory leak

[balporig]

Which version of floccus are you using?

5.1.0

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 125.0.3

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Setup

75k bookmarks spread across 8 non-nested profiles synced between several Firefox and Chromium based browsers on different platforms with auto-sync disabled

Issue

When opening Firefox for the first time there is huge memory spike up to 40 GB. Each time you reopen the browser there is significant spike, that takes few minutes to reach it's peak and disappears after several minutes. With auto-sync disabled there shouldn't be any background processing on startup. The issue is not present in Chromium based browsers

Expected Behavior

There shouldn't be any noticeable memory usage on startup with auto-sync disabled

To Reproduce

You need couple of profiles each with few thousand bookmarks, the more profiles with more bookmarks, the larger the memory spike

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

75k bookmarks, huh?

I know exactly which code triggers this :D :S and it's hard to circumvent 🤔

[balporig]

Yep, 10 years worth of research :)

Interesting, can you point to the code to have a look?

Looks like #1548 is non issue anymore as long you keep each profile under 5 MB

[marcelklehr]

Interesting, can you point to the code to have a look?

You can see it in the fixing commit

[marcelklehr]

Looks like #1548 is non issue anymore as long you keep each profile under 5 MB

Interesting