Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDAV lock not removed after 4 days #1594

Closed
1 task
andbenn opened this issue May 8, 2024 · 6 comments · Fixed by #1598
Closed
1 task

WebDAV lock not removed after 4 days #1594

andbenn opened this issue May 8, 2024 · 6 comments · Fixed by #1598
Labels
Projects

Comments

@andbenn
Copy link

andbenn commented May 8, 2024

Which version of floccus are you using?

5.1.0

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Brave

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

Fastmail

Describe the Bug

Similar or the same as #1572 filed earlier by me.

My work browser syncs both a profile of bookmarks and tabs to webdav. It's the only browser hitting the profiles, as no other browser is. The lock file has been there since Saturday morning, it's now Tuesday evening. I noticed today some browser tabs keep reappearing. Saturday morning is strange, as my work laptop was not powered on then

I also have a free NextCloud instance I can redirect my profiles to on the other side of the planet. I may do that to attempt to rule out a floccus issue versus a Fastmail webdav issue in the next few days. Would appreciate thoughts, in case they arrive before I make a transition.

I wish the icon had told me that a sync had been pending for over a day.

I'm going to rename the lock file and save it. I can easily reenter this scenario by reversing it. Let me know if you'd want me to do anything.

Expected Behavior

Sync's to clear after a certain time period as written up online

To Reproduce

Tab and or Browser webdav to Fastmail. Not a popular or easy case to handle.

Debug log provided

  • I have provided a debug log file
@andbenn andbenn added the bug label May 8, 2024
@github-actions github-actions bot added this to Backlog in Floccus May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@andbenn
Copy link
Author

andbenn commented May 9, 2024

I saved the tab profile and the tab lockfile. Such that I should be able to pause that browser, rename and shift these files around, and regenerate the scenario.

Two of my tabs were open on Brave searches. After renaming the lock file, the two search tabs kept reappearing and duplicating. Not sure why. I ended up pausing the profile, and renaming both, then pushing my browser back out.

Let me know if you'd want me to do anything. i haven't had time yet to try moving them to my NextCloud space.

@marcelklehr
Copy link
Member

How large are your bookmarks files on the webdav share?

@andbenn
Copy link
Author

andbenn commented May 9, 2024

Tabs are 21 KB
Bookmarks are 282 KB

@marcelklehr
Copy link
Member

Ok, that's not a lot. there goes that theory :D

@marcelklehr
Copy link
Member

Aha! I was able to reproduce!

marcelklehr added a commit that referenced this issue May 9, 2024
fixes #1594
fixes #1548

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Floccus automation moved this from Backlog to Done May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants