Skip to content

Commit

Permalink
Modified "default" so it can be used alone.
Browse files Browse the repository at this point in the history
I'm not sure the best way to work "default" into the DSL since it's
effectively stating that there is only a CC+NDC and no Local part.
The DSL expects both.
  • Loading branch information
mrchucho committed Jul 15, 2011
1 parent d0d9a83 commit 47d7409
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/phony/countries.rb
Expand Up @@ -496,7 +496,7 @@

country '970', fixed(2) >> split(3,2,2) # Reserved
country '971', fixed(2) >> split(3,2,2) # United Arab Emirates
country '972', fixed(2) >> split(3,2,2) # Israel (State of)
country '972', default # Israel (State of)
country '973', fixed(2) >> split(3,2,2) # Bahrain (Kingdom of)
country '974', fixed(2) >> split(3,2,2) # Qatar (State of)
country '975', fixed(2) >> split(3,2,2) # Bhutan (Kingdom of)
Expand Down
2 changes: 1 addition & 1 deletion lib/phony/dsl.rb
Expand Up @@ -74,7 +74,7 @@ def match regex, options = {}
NationalSplitters::Regex.instance_for regex, options[:on_fail_take]
end
def default
NationalSplitters::Default.instance_for
none >> NationalSplitters::Default.instance_for
end

# Local splitters.
Expand Down
5 changes: 5 additions & 0 deletions spec/lib/phony_spec.rb
Expand Up @@ -193,6 +193,11 @@
Phony.format('414436435').should == '+41 44 364 35'
end
end
context '"unsupported" countries' do
it 'handles normalizing, then formatting' do
Phony.format(Phony.normalize('+880-321 5560 5220')).should == '+880 32155605220'
end
end
end

context "speed" do
Expand Down

0 comments on commit 47d7409

Please sign in to comment.