* Remove unused variables

floere · Mar 12, 2014 · 5f85380 · 5f85380
1 parent 700ac4a
commit 5f85380
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 14 deletions.
diff --git a/lib/phony/countries/ireland.rb b/lib/phony/countries/ireland.rb
@@ -9,8 +9,6 @@
 # http://www.comreg.ie/_fileupload/publications/ComReg03147.pdf
 # http://en.wikipedia.org/wiki/Telephone_numbers_in_the_Republic_of_Ireland
 #
-handlers = []
-
 ndcs_with_5_subscriber_digits = [
   ('22'..'29').to_a, # Mallow, Bandon, Youghal, Fermoy, Macroom, Bantry, Skibbereen, Kanturk
   '402',  # Arklow
@@ -73,4 +71,4 @@
                  match(/^(8\d).+$/)                      >> split(3,4) | # mobile
                  fixed(3)                                >> split(6)     # Fallback
 
-end
+end
diff --git a/lib/phony/countries/malaysia.rb b/lib/phony/countries/malaysia.rb
@@ -12,7 +12,7 @@
   '9', # Kelantan, Pahang (except Cameron Highlands & Genting Highlands) & Terengganu
 ]
 mobile = %w{ 10 11 12 13 14 153 154 156 158 16 17 18 19 }
-service = %w{ 100 101 102 103 104 108 991 994 995 999 }  # Emergeny and Service numbers, only 3 digits long
+# service = %w{ 100 101 102 103 104 108 991 994 995 999 }  # Emergeny and Service numbers, only 3 digits long
 freephone = %w{ 300 700 800 }
 
 Phony.define do
@@ -21,4 +21,4 @@
                 one_of(mobile)  >> split(3,4)   | # Mobile
                 one_of(ndcs)    >> split(8)     | # 1-digit NDCs
                 fixed(2)        >> split(8)       # 2-digit NDCs (Also, fallback)
-end
+end
diff --git a/lib/phony/country.rb b/lib/phony/country.rb
@@ -112,10 +112,10 @@ def vanity? national_number
     #
     #
     def vanity_to_number vanity_number
-      zero, ndc, *rest = split vanity_number
+      _, ndc, *rest = split vanity_number
       "#{ndc}#{Vanity.replace(rest.join)}"
     end
 
   end
 
-end
+end
diff --git a/lib/phony/country_codes.rb b/lib/phony/country_codes.rb
@@ -127,15 +127,15 @@ def format_local space, parts_ary
     #
     #
     def service? number
-      country, cc, rest = split_cc number
+      country, _, rest = split_cc number
       country.service? rest
     end
     def mobile? number
-      country, cc, rest = split_cc number
+      country, _, rest = split_cc number
       country.mobile? rest
     end
     def landline? number
-      country, cc, rest = split_cc number
+      country, _, rest = split_cc number
       country.landline? rest
     end
 
@@ -179,7 +179,7 @@ def plausible? number, hints = {}
       # Country specific tests.
       #
       country.plausible? rest, hints
-    rescue StandardError => e
+    rescue StandardError
       return false
     end
 

diff --git a/spec/functional/plausibility_spec.rb b/spec/functional/plausibility_spec.rb
@@ -20,7 +20,6 @@ def self.it_is_correct_for(country_name, options={})
           correct = [*sample]
 
           shortest = correct.min_by{|x| x.scan(/\d/).length}
-          longest = correct.max_by{|x| x.scan(/\d/).length}
           incorrect = [shortest.sub(/\d\s*\z/, '')] # , longest + '0']
 
           correct.each do |value|

diff --git a/spec/spec_helper_extensions.rb b/spec/spec_helper_extensions.rb
@@ -12,7 +12,7 @@ module SpecHelperExtensions
   #
   begin
     require File.expand_path '../performance_ratio', __FILE__
-  rescue LoadError => e
+  rescue LoadError
     Phony::PerformanceRatio = 0 # Ignore speed tests by default.
   end
   def performance_of &block
@@ -22,4 +22,4 @@ def performance_of &block
     result * Phony::PerformanceRatio
   end
 
-end
+end