Italy phone numbers with 2 digit NDCs will not format correctly

[bekki]

A number like "390612345678" will not format correctly. The last digit will be dropped and the formatted number will end up looking like this: "+39 06 123 4567"

The problem is in the last handler defined in phony/countries/italy.rb. The local splitter there will split the number into three digits and then four, dropping off the last digit. This works just fine for 3 or more digit NDCs obviously. :)

[floere]

Thanks for reporting! Inclined to fix it and send a pull request? :)

On 24.01.2012, at 15:05, Bekki Hui Jamreply@reply.github.com wrote:

A number like "390612345678" will not format correctly. The last digit will be dropped and the formatted number will end up looking like this: "+39 06 123 4567"

The problem is in the last handler defined in phony/countries/italy.rb. The local splitter there will split the number into three digits and then four, dropping off the last digit. This works just fine for 3 or more digit NDCs obviously. :)

---

Reply to this email directly or view it on GitHub:
#33

[bekki]

Will do!

[floere]

Thank you, Bekki!

[floere]

@PixelVixen Ok, pulled your request. Thanks very much for participating!

As a note for the future: The countries specs are in spec/lib/phony/countries_spec.rb and can be run with rake spec after a bundle install. Cheers!

Will release 1.6.2 in the next half hour.

[floere]

Phony 1.6.2 is released, also see contributors https://github.com/floere/phony/wiki/Contributors. Thanks! :)