Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Côte d'Ivoire]: Fixed parsing of mobile numbers and fixed splitting to ... #244

Merged
merged 1 commit into from Apr 15, 2015

Conversation

tpena
Copy link
Contributor

@tpena tpena commented Apr 15, 2015

...reflect ITU specification

References:
[0] ITU
http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000310001PDFE.pdf
[1] Telephone numbers in Ivory Coast
http://en.wikipedia.org/wiki/Telephone_numbers_in_Ivory_Coast

Fixes:
The Ivory Coast numbers do not have a trunk code leading to the situation that valid numbers such as '22507123456' would be normalized as '2257123456'. Furthermore, if you look at the
allocation of both landline and mobile numbers given in both [0] and [1], the area code is fixed to 2 digits. In the case of landlines, the ITU spec will list out 3 digit area codes
but this is only because they are making the separation based on telecom provider as well. That is, the 3rd digit of the national subscriber number signifies the network operator. But viewing
it from the zones listed in the "Usage of E.164 number" column, it is clear that the zones are allocated 2-digits. This also matches up with the information in [1] as well as the way the
numbers are formatted in [0]

Côte d'Ivoire
Tel: +225 20 34 43 74
Fax: +225 20 34 43 75
URL: www.artci.ci

As a result, the parsing of Ivory Coast numbers will split the NSN into 4 2-digit numbers. Furthermore, we need to set the trunk code to an empty string to prevent it from being removed
during normalization (similar to how it is done for Italy)

…to reflect ITU specification

References:
[0] ITU
    http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000310001PDFE.pdf
[1] Telephone numbers in Ivory Coast
    http://en.wikipedia.org/wiki/Telephone_numbers_in_Ivory_Coast

Fixes:
The Ivory Coast numbers do not have a trunk code leading to the situation that valid numbers such as '22507123456' would be normalized as '2257123456'. Furthermore, if you look at the
allocation of both landline and mobile numbers given in both [0] and [1], the area code is fixed to 2 digits. In the case of landlines, the ITU spec will list out 3 digit area codes
but this is only because they are making the separation based on telecom provider as well. That is, the 3rd digit of the national subscriber number signifies the network operator. But viewing
it from the zones listed in the "Usage of E.164 number" column, it is clear that the zones are allocated 2-digits. This also matches up with the information in [1] as well as the way the
numbers are formatted in [0]

Côte d'Ivoire
Tel: +225 20 34 43 74
Fax: +225 20 34 43 75
URL: www.artci.ci

As a result, the parsing of Ivory Coast numbers will split the NSN into 4 2-digit numbers. Furthermore, we need to set the trunk code to an empty string to prevent it from being removed
during normalization (similar to how it is done for Italy)
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.27% when pulling db12539 on tpena:feature/ivory-coast-parsing into 079693d on floere:master.

floere added a commit that referenced this pull request Apr 15, 2015
[Côte d'Ivoire]: Fixed parsing of mobile numbers and fixed splitting to ...
@floere floere merged commit a3b1b9d into floere:master Apr 15, 2015
@floere
Copy link
Owner

floere commented Apr 15, 2015

Thanks! 👍

@floere
Copy link
Owner

floere commented Apr 15, 2015

Released in 2.12.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants