Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve japanese #253

Merged
merged 2 commits into from May 26, 2015
Merged

Improve japanese #253

merged 2 commits into from May 26, 2015

Conversation

nabetaro
Copy link
Contributor

Hi,
Thank you for the great lib.

I wish improve lib to Japanese telephone number.
Telephone number in Japan is:

  • usually [Area Code] - [Local Exchange Number] - [Subscriber Number].
  • [Subscriber Number] is 4 digits.
  • Osaka's area code (6) and UPT code (60) are confused.

see also: http://www.soumu.go.jp/main_sosiki/joho_tsusin/eng/TelNumber/Numbering.html

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.05% when pulling 271f37f on nabetaro:improve_japanese into 46262a5 on floere:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.02% when pulling 271f37f on nabetaro:improve_japanese into 46262a5 on floere:master.

floere added a commit that referenced this pull request May 26, 2015
@floere floere merged commit 81072fe into floere:master May 26, 2015
@floere
Copy link
Owner

floere commented May 26, 2015

Excellent PR, thank you! I've released 2.14.1 with this code.

Just to confirm: the numbers have dashes - between all parts of the number, like in https://github.com/floere/phony/blob/master/qed/country-specific.md#japan? (see the right hand side)

@nabetaro
Copy link
Contributor Author

Thank you very much!
I'll use Released gem soon!

It seems the fixed document is OK.

@floere
Copy link
Owner

floere commented May 27, 2015

Thanks. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants