Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed Estonian mobiles #68

Merged
merged 3 commits into from Jan 21, 2013
Merged

fixed Estonian mobiles #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d50fa
Update lib/phony/countries.rb
Dec 12, 2012
b7bfb82
tests are passing
Dec 12, 2012
b7c075d
better view
Dec 12, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/phony/countries.rb
View file
Open in desktop
Expand Up @@ -428,9 +428,8 @@

# Estonia
country '372',
match(/^(5\d\d\d)\d+$/) >> split(4) | # Mobile
match(/^((?:70|8[12])\d\d)\d+$/) >> split(4) | # Mobile
fixed(3) >> split(4) # 3-digit NDCs
match(/^((5\d|8[12])\d\d)\d+$/) >> split(4) | # Mobile
fixed(3) >> split(4) # 3-digit NDCs

country '373', todo # Moldova
country '374', todo # Armenia
Expand Down
1 change: 0 additions & 1 deletion spec/lib/phony/countries_spec.rb
View file
Open in desktop
Expand Up @@ -95,7 +95,6 @@ def self.it_splits number, expected
it_splits '37281231234', ['372', '8123', '1234'] # Mobile
it_splits '37282231234', ['372', '8223', '1234'] # Mobile
it_splits '37283212345', ['372', '832', '12345'] # Mobile
it_splits '37270121234', ['372', '7012', '1234'] # Premium
end
describe 'Finland' do
it_splits '3589123123', ['358', '9', '123', '123'] # Helsinki
Expand Down