Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - connect nodes via not shortest line distance #194

Closed
trbritt opened this issue Jan 31, 2023 · 2 comments · Fixed by #197
Closed

UI - connect nodes via not shortest line distance #194

trbritt opened this issue Jan 31, 2023 · 2 comments · Fixed by #197
Assignees

Comments

@trbritt
Copy link
Collaborator

trbritt commented Jan 31, 2023

In order to design an active feedback loop, very often nodes at the end of the chain will need to be connected to a comparator at the beginning. As of right now, the nodes are connected by the shortest curved path possible, but for these applications this creates a connection that clutters the rest of the nodes (see below).

Is it possible to intentionally increase the length of the curve connecting the nodes to move out of the way, maybe drop completely below the nodes like a 'U' shape?

image

@jackparmer
Copy link
Collaborator

jackparmer commented Jan 31, 2023

One way that we could do this is to detect edge-node collisions upon connecting a node:

https://reactflow.dev/docs/examples/interaction/validation/

Then use a custom edge that calculates its trajectory to avoid node positions:

https://reactflow.dev/docs/examples/edges/custom-connectionline/

Seems like a lot of work though 😑 I'm surprised React Flow doesn't have an out-of-the-box solution

@jackparmer
Copy link
Collaborator

Inquired here: xyflow/xyflow#2790

@jackparmer jackparmer removed the good first issue Good for newcomers label Feb 2, 2023
@smahmed776 smahmed776 linked a pull request Feb 4, 2023 that will close this issue
flojoy-bot bot pushed a commit that referenced this issue Jul 25, 2023
izi-on added a commit that referenced this issue Jul 26, 2023
…ls-when-node-has-multiple-outputs

[nodes] Merge pull request #194 from flojoy-io/reda-fix-tmin-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants