LabView like wire types #1125
Merged
LabView like wire types #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smahmed776
commented
Mar 7, 2024
•
smahmed776
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LatentDream
requested changes
Mar 9, 2024
There was a problem hiding this comment.
I changed two little thing, just some text box that was not at the right place and two connection that were inverted.
- We can't see which node raise an error when an error occurs, which makes it kinda hard to "debug" and we also can not see the error. Not sure if the regression is from this PR or the clean up one, cc: @39bytes
- Same for the visual effect of showing which block is currently running. It's not on right now
LatentDream
previously approved these changes
Mar 11, 2024
39bytes
reviewed
Mar 11, 2024
itsjoeoui
requested changes
Mar 11, 2024
itsjoeoui
requested changes
Mar 11, 2024
itsjoeoui
requested changes
Mar 11, 2024
There was a problem hiding this comment.
CleanShot.2024-03-11.at.11.50.34.mp4
The SVG should also adapt to the scale as you resize it imo, the video is from this reactflow example: https://reactflow.dev/examples/nodes/shapes
I sent the code of this example in Slack a bit ago 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.