Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Maximum Depth Reached when loading app containing Knob Ctrl #225

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Fix: Maximum Depth Reached when loading app containing Knob Ctrl #225

merged 1 commit into from
Feb 18, 2023

Conversation

smahmed776
Copy link
Collaborator

Fixed a bug in KnobCtrl.tsx that caused infinite re-rendering...

@smahmed776 smahmed776 changed the base branch from main to develop February 17, 2023 22:40
@smahmed776 smahmed776 self-assigned this Feb 17, 2023
@smahmed776 smahmed776 linked an issue Feb 17, 2023 that may be closed by this pull request
Maximum Depth Reached when loading app containing Knob Ctrl #198
Closed
SifatIbna
SifatIbna approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@SifatIbna SifatIbna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smahmed776 smahmed776 merged commit 4008dac into develop Feb 18, 2023
@smahmed776 smahmed776 deleted the knob-issue branch February 18, 2023 17:53
flojoy-bot bot pushed a commit that referenced this pull request Aug 10, 2023
@39bytes
update submodule to commit: Format docstrings for viz nodes (#225)
5b4a198
@itsjoeoui itsjoeoui mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SifatIbna SifatIbna SifatIbna approved these changes

@dev-nested dev-nested Awaiting requested review from dev-nested

Assignees

@smahmed776 smahmed776

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximum Depth Reached when loading app containing Knob Ctrl
2 participants
@smahmed776 @SifatIbna