Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Play Button: Disables if the server in disconnected or Connecting State #228

Merged
merged 1 commit into from
Feb 22, 2023
Merged

UI/Play Button: Disables if the server in disconnected or Connecting State #228

merged 1 commit into from
Feb 22, 2023

Conversation

SifatIbna
Copy link
Contributor

This Feature Includes-

  • If the server in disconnected or connecting state the Play Button is disables
  • Added a new onError Method to catch the server error or failing state.

Feature Overview:

play-button

smahmed776
smahmed776 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@smahmed776 smahmed776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..

@SifatIbna SifatIbna merged commit 187b96f into develop Feb 22, 2023
@SifatIbna SifatIbna deleted the ui/play-button branch February 22, 2023 20:37
@smahmed776 smahmed776 linked an issue Mar 16, 2023 that may be closed by this pull request
Show Some Alert and Disable Play Button When WebSocket Connection Is Disconnected/Reconnecting #216
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smahmed776 smahmed776 smahmed776 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Some Alert and Disable Play Button When WebSocket Connection Is Disconnected/Reconnecting
2 participants
@SifatIbna @smahmed776