Support more urls #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to return anything else.
Some Mailing List Archive listings don't contain /pipermail in path. Instead of simply giving up in this case, try to parse it as a pipermail listing, and fail if we were not able to get any mbox URLs from it.
Also, replace `click.echo` calls with calls to the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does relax the requirement of having
/pipermailin the URL, and just tries to parse a URL not directly pointing to an mbox file as a list, and will fail if it didn't manage to retrieve any mbox files.Fixes importing for
lists.freedesktop.org.