Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken focus field for non image file types #27

Closed
ghost opened this issue Jun 20, 2018 · 4 comments
Closed

Broken focus field for non image file types #27

ghost opened this issue Jun 20, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jun 20, 2018

Thank you very much for your field! It is a nice addition to the Kirby universe. 👍

I wanted to ask if it is normal for non-image fields to show a broken focus field? Maybe we can hide the field based on the supported mime types?

@flokosiol
Copy link
Owner

flokosiol commented Jun 20, 2018

Thanks for reporting.

In previous versions there was a $file->canHaveThumb() Kirby core method which did the check, but it seems to be deprecated. I will push a fix to the development branch in a minute. Would be awesome, if you could check it!?

@flokosiol
Copy link
Owner

@ghost
Copy link
Author

ghost commented Jun 21, 2018

The dev version of the plugin fixes the problem!

@flokosiol
Copy link
Owner

Great. Thanks for testing. I will try to release a new version as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant