fix: nanargmin with all nan slice #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #134 +/- ##
========================================
Coverage 95.58% 95.58%
========================================
Files 47 47
Lines 3194 3194
========================================
Hits 3053 3053
Misses 141 141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the
DiscreteVoronoiModel. The model crashes when frame are all NaN because of thenp.nanargmin()function. This is because of type stability of the return of that function as its supposed to return integers. See pydata/xarray#4481 and pydata/xarray#3884.One easy fix for this would be to apply the
np.nanargmin()only to slices that are not all NaN usingnp.where(). However, masking the hole array before the loop and catching the all NaN slices early might be a more elegant and better performing option.