java_model: generate OFErrorMsg accessor for ErrorCause data #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the loxigen model, the virtual of_error_msg superclass does not have a data field) (but all its concrete subclasses have one). This little patch makes the java model generate a "data" contract in the interface anyway, which is useful for error handling schemes that depend on the type of the causing message.
|
Test PASSed. |
| @@ -587,6 +587,8 @@ def virtual_members(self): | |||
| if not find(lambda x: x.name == "mask", self.ir_model_members): | |||
| virtual_members.append( | |||
| JavaVirtualMember(self, "mask", find(lambda x: x.name == "value", self.ir_model_members).java_type)) | |||
| elif self.name =="OFErrorMsg": | |||
| virtual_members += [ JavaVirtualMember(self, "data", java_type.error_cause_data) ] | |||
There was a problem hiding this comment.
why not virtual_members.append for consistency?
|
Fair enough -- it's a little bit inconsistent anyway tho, because other cases use |
|
Didn't even look outside -5/+5 lines to notice that. In that case it can be cleaned up later... |
|
LGTM |
|
ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2014.12.02.0718-m.loxigen.master/abat.log |
bsn-abat
pushed a commit
to floodlight/loxigen-artifacts
that referenced
this pull request
Dec 2, 2014
Loxigen Head commit floodlight/loxigen@fcc3792 commit fcc37923e9308155c9c61534e37061cfc3c6cdde Merge: 15cadf5 4d0752b Author: abat <abat@bigswitch.com> Date: Mon Dec 1 23:18:33 2014 -0800 Merge into master from pull request #356: java_model: generate OFErrorMsg accessor for ErrorCause data (floodlight/loxigen#356) commit 4d0752b46a4b0a18ad307b64d83ff6e9d011c46f Author: Andreas Wundsam <andreas.wundsam@bigswitch.com> Date: Mon Dec 1 13:14:07 2014 -0800 java_model: generate OFErrorMsg accessor for ErrorCause data in the loxigen model, the virtual of_error_msg superclass does not have a data field) (but all its concrete subclasses have one). This little patch makes the java model generate a "data" contract in the interface anyway, which is useful for error handling schemes that depend on the type of the causing message.
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
bsn-abat
pushed a commit
that referenced
this pull request
Dec 2, 2014
java_model: generate OFErrorMsg accessor for ErrorCause data (#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @Sovietaced @vishnu-emmadi @rlane
in the loxigen model, the virtual of_error_msg superclass does not have
a data field) (but all its concrete subclasses have one). This little
patch makes the java model generate a "data" contract in the interface
anyway, which is useful for error handling schemes that depend on the
type of the causing message.